[PATCH 01/19] lirc_dev: clarify error handling

[David Härdeman]

If an error is generated, it is more logical to error out ASAP.

Signed-off-by: David Härdeman <da...@hardeman.nu>
---
 drivers/media/rc/lirc_dev.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
index db1e7b70c998..9c1d55e41e34 100644
--- a/drivers/media/rc/lirc_dev.c
+++ b/drivers/media/rc/lirc_dev.c
@@ -282,7 +282,7 @@ EXPORT_SYMBOL(lirc_unregister_driver);
 int lirc_dev_fop_open(struct inode *inode, struct file *file)
 {
        struct irctl *ir;
-       int retval = 0;
+       int retval;
 
        if (iminor(inode) >= MAX_IRCTL_DEVICES) {
                pr_err("open result for %d is -ENODEV\n", iminor(inode));
@@ -323,9 +323,11 @@ int lirc_dev_fop_open(struct inode *inode, struct file 
*file)
 
        ir->open++;
 
-error:
        nonseekable_open(inode, file);
 
+       return 0;
+
+error:
        return retval;
 }
 EXPORT_SYMBOL(lirc_dev_fop_open);