On 21/07/17 12:57, Hans Verkuil wrote:
> From: Hans Verkuil <[email protected]>
>
> Don't use driver_version from struct media_device, just return
> LINUX_VERSION_CODE as the other media subsystems do.
>
> The driver_version field in struct media_device will be removed
> in the following patches.
>
> Signed-off-by: Hans Verkuil <[email protected]>
> ---
> drivers/media/media-device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
> index fce91b543c14..7ff8e2d5bb07 100644
> --- a/drivers/media/media-device.c
> +++ b/drivers/media/media-device.c
> @@ -71,7 +71,7 @@ static int media_device_get_info(struct media_device *dev,
>
> info->media_version = MEDIA_API_VERSION;
Related question about media_version: would it make sense to change this to
LINUX_VERSION_CODE as well? This too has never been changed from when it was
first introduced, making it pointless as a way for applications to detect
when features were added.
Unfortunately MEDIA_API_VERSION is defined in the public media.h header, but
we can mark it unused. This define isn't documented in the spec, BTW.
Regards,
Hans
> info->hw_revision = dev->hw_revision;
> - info->driver_version = dev->driver_version;
> + info->driver_version = LINUX_VERSION_CODE;
>
> return 0;
> }
>
