On Mon, Sep 18, 2017 at 4:56 PM, Sakari Ailus <sakari.ai...@linux.intel.com> wrote: > Hi Rob, > > > Rob Herring wrote: >> >> On Mon, Sep 11, 2017 at 11:00:04AM +0300, Sakari Ailus wrote: >>> >>> Document optional lens-focus and flash properties for the smiapp driver. >>> >>> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> >>> --- >>> Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> >> Acked-by: Rob Herring <r...@kernel.org> > > > Thanks for the ack. There have been since a few iterations of the set, and > the corresponding patch in v13 has minor changes to this:
My review script can't deal with subject changes... > <URL:http://www.spinics.net/lists/linux-media/msg121929.html> > > Essentially "flash" was renamed to "flash-leds" as the current flash devices > we have are all LEDs and the referencing assumes LED framework's ways to > describe LEDs. The same change is present in the patch adding the property So we're kind of creating a binding that mirrors the gpio bindings (*-gpios) which is a bit of an oddball as all other bindings have gone with a fixed property name and then a *-names property to name them. The main downside to this form is a prefixed property name is harder to parse and validate. So perhaps we should follow the more common pattern, but we're not really describing a h/w connection just an association. And now we also have the trigger source binding to associate LEDs with device nodes, so perhaps that should be used here. We shouldn't really have 2 ways to associate things in DT even if how that gets handled in the kernel is different. Rob
