Hi, Andy, > -----Original Message----- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Andy Shevchenko > Sent: Friday, June 16, 2017 3:53 PM > To: Zhi, Yong <yong....@intel.com> > Cc: Linux Media Mailing List <linux-media@vger.kernel.org>; > sakari.ai...@linux.intel.com; Zheng, Jian Xu <jian.xu.zh...@intel.com>; > tf...@chromium.org; Mani, Rajmohan <rajmohan.m...@intel.com>; > Toivonen, Tuukka <tuukka.toivo...@intel.com> > Subject: Re: [PATCH v2 08/12] intel-ipu3: params: compute and program ccs > > On Thu, Jun 15, 2017 at 1:19 AM, Yong Zhi <yong....@intel.com> wrote: > > A collection of routines that are mainly responsible to calculate the > > acc parameters. > > > +static unsigned int ipu3_css_scaler_get_exp(unsigned int counter, > > + unsigned int divider) { > > + unsigned int i = 0; > > + > > + while (counter <= divider / 2) { > > + divider /= 2; > > + i++; > > + } > > + > > + return i; > > We have a lot of different helpers including one you may use instead of this > function. > > It's *highly* recommended you learn what we have under lib/ (and not only > there) in kernel bewfore submitting a new version. >
Tried to identify more places that could be re-implemented with lib helpers or more generic method, but we failed to spot any obvious candidate thus far. > -- > With Best Regards, > Andy Shevchenko
