The current code doesn't report tuner lock properly if the
tuner get_status callback is not available, as reported by
smatch:
        drivers/media/dvb-frontends/stv090x.c:2220 stv090x_get_coldlock() 
error: uninitialized symbol 'reg'.

Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
---
 drivers/media/dvb-frontends/stv090x.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/media/dvb-frontends/stv090x.c 
b/drivers/media/dvb-frontends/stv090x.c
index 7ef469c0c866..0f375df13fbe 100644
--- a/drivers/media/dvb-frontends/stv090x.c
+++ b/drivers/media/dvb-frontends/stv090x.c
@@ -2215,13 +2215,12 @@ static int stv090x_get_coldlock(struct stv090x_state 
*state, s32 timeout_dmd)
                if (state->config->tuner_get_status) {
                        if (state->config->tuner_get_status(fe, &reg) < 0)
                                goto err_gateoff;
+                       if (reg)
+                               dprintk(FE_DEBUG, 1, "Tuner phase locked");
+                       else
+                               dprintk(FE_DEBUG, 1, "Tuner unlocked");
                }
 
-               if (reg)
-                       dprintk(FE_DEBUG, 1, "Tuner phase locked");
-               else
-                       dprintk(FE_DEBUG, 1, "Tuner unlocked");
-
                if (stv090x_i2c_gate_ctrl(state, 0) < 0)
                        goto err;
 
-- 
2.13.6

Reply via email to