On 02/09/18 13:17, Sakari Ailus wrote: > On Thu, Feb 08, 2018 at 09:36:51AM +0100, Hans Verkuil wrote: >> MEDIA_IOC_SETUP_LINK didn't zero the reserved field of the media_link_desc >> struct. Do so in media_device_setup_link(). >> >> Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> >> --- >> drivers/media/media-device.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c >> index e79f72b8b858..afbf23a19e16 100644 >> --- a/drivers/media/media-device.c >> +++ b/drivers/media/media-device.c >> @@ -218,6 +218,8 @@ static long media_device_setup_link(struct media_device >> *mdev, >> if (link == NULL) >> return -EINVAL; >> >> + memset(linkd->reserved, 0, sizeof(linkd->reserved)); >> + > > Doesn't media_device_enum_links() need the same for its reserved field?
enum_links() already zeroes this (actually the whole media_link_desc struct is zeroed). Regards, Hans > >> /* Setup the link on both entities. */ >> return __media_entity_setup_link(link, linkd->flags); >> } >> -- >> 2.15.1 >> >