From: Hans Verkuil <>

commit 273caa260035c03d89ad63d72d8cd3d9e5c5e3f1 upstream.

If the device is of type VFL_TYPE_SUBDEV then vdev->ioctl_ops
is NULL so the 'if (!ops->vidioc_query_ext_ctrl)' check would crash.
Add a test for !ops to the condition.

All sub-devices that have controls will use the control framework,
so they do not have an equivalent to ops->vidioc_query_ext_ctrl.
Returning false if ops is NULL is the correct thing to do here.

Fixes: b8c601e8af ("v4l2-compat-ioctl32.c: fix ctrl_is_pointer")

Signed-off-by: Hans Verkuil <>
Acked-by: Sakari Ailus <>
Reported-by: Laurent Pinchart <>
Reviewed-by: Laurent Pinchart <>
Signed-off-by: Mauro Carvalho Chehab <>
 drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c 
index c8dd39884f6e..da55322bbb0f 100644
--- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
+++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
@@ -612,7 +612,7 @@ static inline bool ctrl_is_pointer(struct file *file, u32 
                return ctrl && ctrl->is_ptr;
-       if (!ops->vidioc_query_ext_ctrl)
+       if (!ops || !ops->vidioc_query_ext_ctrl)
                return false;
        return !ops->vidioc_query_ext_ctrl(file, fh, &qec) &&

Reply via email to