Hi Niklas, Thank you for the patch.
On Friday, 2 March 2018 03:57:21 EET Niklas Söderlund wrote: > From: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> > > Add compatible strings for r8a7743 and r8a7745. No driver change > is needed as "renesas,rcar-gen2-vin" will activate the right code. > However, it is good practice to document compatible strings for the > specific SoC as this allows SoC specific changes to the driver if > needed, in addition to document SoC support and therefore allow > checkpatch.pl to validate compatible string values. > > Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> > Reviewed-by: Biju Das <biju....@bp.renesas.com> > Reviewed-by: Simon Horman <horms+rene...@verge.net.au> > Acked-by: Rob Herring <r...@kernel.org> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt > b/Documentation/devicetree/bindings/media/rcar_vin.txt index > 0ac715a5c331bc26..c60e6b0a89b67a8c 100644 > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > @@ -6,6 +6,8 @@ family of devices. The current blocks are always slaves and > suppot one input channel which can be either RGB, YUYV or BT656. > > - compatible: Must be one or more of the following > + - "renesas,vin-r8a7743" for the R8A7743 device > + - "renesas,vin-r8a7745" for the R8A7745 device > - "renesas,vin-r8a7778" for the R8A7778 device > - "renesas,vin-r8a7779" for the R8A7779 device > - "renesas,vin-r8a7790" for the R8A7790 device > @@ -14,7 +16,8 @@ channel which can be either RGB, YUYV or BT656. > - "renesas,vin-r8a7793" for the R8A7793 device > - "renesas,vin-r8a7794" for the R8A7794 device > - "renesas,vin-r8a7795" for the R8A7795 device > - - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 compatible device. > + - "renesas,rcar-gen2-vin" for a generic R-Car Gen2 or RZ/G1 compatible > + device. > - "renesas,rcar-gen3-vin" for a generic R-Car Gen3 compatible device. > > When compatible with the generic version nodes must list the -- Regards, Laurent Pinchart