Hi Tomasz,
On 05/18/2018 04:53 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> HFI version 4xx can pass more properties in the sequence change
>> event, extend the event structure with them.
>
>> Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org>
>> ---
>> drivers/media/platform/qcom/venus/hfi.h | 9 ++++++
>> drivers/media/platform/qcom/venus/hfi_msgs.c | 46
> ++++++++++++++++++++++++++++
>> 2 files changed, 55 insertions(+)
>
>> diff --git a/drivers/media/platform/qcom/venus/hfi.h
> b/drivers/media/platform/qcom/venus/hfi.h
>> index 5466b7d60dd0..21376d93170f 100644
>> --- a/drivers/media/platform/qcom/venus/hfi.h
>> +++ b/drivers/media/platform/qcom/venus/hfi.h
>> @@ -74,6 +74,15 @@ struct hfi_event_data {
>> u32 tag;
>> u32 profile;
>> u32 level;
>
> nit; Could we add a comment saying that it showed in 4xx?
Sure, I can add a comment.
>
> [snip]
>
>> + case HFI_PROPERTY_CONFIG_VDEC_ENTROPY:
>> + data_ptr += sizeof(u32);
>> + entropy_mode = *(u32 *)data_ptr;
>> + event.entropy_mode = entropy_mode;
>
> Is the |entropy_mode| local variable necessary?
Isn't GCC smart enough ;) Sure, I can drop entropy_mode local variable.
--
regards,
Stan
