On 25/05/18 15:12, Dan Carpenter wrote:
> In vpbe_enum_outputs() we check if (temp_index >= cfg->num_outputs) but
> the problem is that temp_index can be negative. I've made
> cgf->num_outputs unsigned to fix this issue.
Shouldn't temp_index also be made unsigned? It certainly would make a lot of
sense to do that.
Regards,
Hans
>
> Fixes: 66715cdc3224 ("[media] davinci vpbe: VPBE display driver")
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
> ---
> v2: fix it a different way
>
> diff --git a/include/media/davinci/vpbe.h b/include/media/davinci/vpbe.h
> index 79a566d7defd..180a05e91497 100644
> --- a/include/media/davinci/vpbe.h
> +++ b/include/media/davinci/vpbe.h
> @@ -92,7 +92,7 @@ struct vpbe_config {
> struct encoder_config_info *ext_encoders;
> /* amplifier information goes here */
> struct amp_config_info *amp;
> - int num_outputs;
> + unsigned int num_outputs;
> /* Order is venc outputs followed by LCD and then external encoders */
> struct vpbe_output *outputs;
> };
>
