On Mon, Jun 11, 2018 at 11:29:17AM +0200, Hugues Fruchet wrote: > Add support of module being physically mounted upside down. > In this case, mirror and flip are enabled to fix captured images > orientation. > > Signed-off-by: Hugues Fruchet <hugues.fruc...@st.com> > --- > .../devicetree/bindings/media/i2c/ov5640.txt | 3 +++
Please split bindings to separate patches. > drivers/media/i2c/ov5640.c | 28 > ++++++++++++++++++++-- > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.txt > b/Documentation/devicetree/bindings/media/i2c/ov5640.txt > index 8e36da0..f76eb7e 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov5640.txt > +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.txt > @@ -13,6 +13,8 @@ Optional Properties: > This is an active low signal to the OV5640. > - powerdown-gpios: reference to the GPIO connected to the powerdown pin, > if any. This is an active high signal to the OV5640. > +- rotation: integer property; valid values are 0 (sensor mounted upright) > + and 180 (sensor mounted upside down). Didn't we just add this as a common property? If so, just reference the common definition. If not, it needs a common definition.