If info->pdata is NULL then we would oops on the next line.  And we can
flip the "ret" test around and give up if a failure has already occured.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/media/i2c/sr030pc30.c b/drivers/media/i2c/sr030pc30.c
index 2a4882cddc51..4ebd00198d34 100644
--- a/drivers/media/i2c/sr030pc30.c
+++ b/drivers/media/i2c/sr030pc30.c
@@ -569,8 +569,8 @@ static int sr030pc30_base_config(struct v4l2_subdev *sd)
        if (!ret)
                ret = sr030pc30_pwr_ctrl(sd, false, false);
 
-       if (!ret && !info->pdata)
-               return ret;
+       if (ret || !info->pdata)
+               return -EIO;
 
        expmin = EXPOS_MIN_MS * info->pdata->clk_rate / (8 * 1000);
        expmax = EXPOS_MAX_MS * info->pdata->clk_rate / (8 * 1000);

Reply via email to