On Wed, Jul 4, 2018 at 10:47 PM Mauro Carvalho Chehab <mchehab+sams...@kernel.org> wrote: > > Right now, satellite tuner drivers specify frequencies in kHz, > while terrestrial/cable ones specify in Hz. That's confusing > for developers. > > However, the main problem is that universal tuners capable > of handling both satellite and non-satelite delivery systems > are appearing. We end by needing to hack the drivers in > order to support such hybrid tuners. > > So, convert everything to specify tuner frequencies in Hz. > > Plese notice that a similar patch is also needed for frontends. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org>
I'm okay with the idea behind this, but I'm not sure I'm behind the way it's being done. What if, rather than changing every tuner range to HZ, instead, to add a new field to indicate the magnitude. This can be Hz, KHz, MHz, etc This way, the ranges would remain unaltered, and userspace can remain unchanged. Although the patch as-is may solve a problem, it might be better to solve it with less impact. -Mike Krufky
