On 08/09/2018 08:37 PM, Mauro Carvalho Chehab wrote:
>> +    get_task_comm(comm, current);
>> +    snprintf(req->debug_str, sizeof(req->debug_str), "%s:%d",
>> +             comm, fd);
> I'm pretty sure we've discussed about get_task_comm(). I don't think 
> we should use it, as the task with queues can be different than
> the one with dequeues. Instead, just give an unique ID for each
> request. That will allow tracking it in a better way, no matter how
> the userspace app is encoded.

The original discussion went back-and-forth a bit, but I'll just
replace it with a unique ID.

> Also, for dynamic debugs, the task ID can easily be obtained by
> passing a parameter to it, with +t:
>       echo "file media_request.c +t" > /sys/kernel/debug/dynamic_debug/control
> or, at the boot time with:
>       dyndbg="file media_request.c +t"
> So, Kernel shouldn't be bothered by having such hacks hardcoded
> at the code.



Reply via email to