hans, >> >> Yes, isif_config_bclamp() set values in the register. > >Huh? That does not explain why apparently bc->horz.win_h_sz_calc can be >larger >than ISIF_HORZ_BC_WIN_H_SIZE_MASK. because the values come from the user and since we can't use the enum for the types, I have to make sure the value is within range. Other way to do is to check the value in the validate() function. I am inclined to do the validation so that the & statements with masks can be removed while setting it in the register.
> >Regards, > > Hans > >> >> > >> >It would be interesting to know if people know of good ways of making >> >awkward >> >code like this more elegant (or at least less awkward). >> > >> >Regards, >> > >> > Hans >> > >> >-- >> >Hans Verkuil - video4linux developer - sponsored by TANDBERG >> >> > >-- >Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html