Hi,
On Thu, 2018-09-13 at 11:53 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 13 Sep 2018 16:40:47 +0200
> Maxime Ripard <maxime.rip...@bootlin.com> escreveu:
>
>
> > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> > @@ -82,10 +82,7 @@ static struct cedrus_format *cedrus_find_format(u32
> > pixelformat, u32 directions,
> > static bool cedrus_check_format(u32 pixelformat, u32 directions,
> > unsigned int capabilities)
> > {
> > - struct cedrus_format *fmt = cedrus_find_format(pixelformat, directions,
> > - capabilities);
> > -
> > - return fmt != NULL;
> > + return cedrus_find_format(pixelformat, directions, capabilities);
> > }
>
> Hmm... just occurred to me... Why do you need this? I mean, you
> could simply do something like:
>
> $ git filter-branch -f --tree-filter 'for i in $(git grep -l
> cedrus_check_format); do \
> sed -E s,\\bcedrus_check_format\\b,cedrus_find_format,g -i $i; done '
> origin/master..
>
> (or just do a sed -E s,\\bcedrus_check_format\\b,cedrus_find_format,g as
> a separate patch)
>
> and get rid of cedrus_check_format() for good.Agreed, the name is probably explicit enough anyway. I probably should have done that in the first place anyway. Cheers, Paul -- Developer of free digital technology and hardware support. Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
signature.asc
Description: This is a digitally signed message part
