At Sun, 13 Dec 2009 10:22:44 -0500,
Devin Heitmueller wrote:
> On Sat, Dec 12, 2009 at 5:34 PM, Mauro Carvalho Chehab
> <> wrote:
> > Hi Devin,
> >
> > It is better to submit the RFC patches to alsa ML for they to take a look.
> >
> > Cheers,
> > Mauro
> Is there something specific you want the ALSA people to review?  There
> are no changes to the ALSA core and this is a pretty
> simple/straightforward PCM capture device modelled after the existing
> cx88/saa7134/em28xx-alsa drivers.  The driver is complete, tested by
> both KernelLabs and the customer.  As far as I know, we generally
> haven't bothered the ALSA people with devices in the /media tree in
> the past unless there was some specific issue.
> If there is something here "out of the ordinary" here that you felt
> the ALSA people would be able to offer some insight on, I would be
> more than happy to send it to them.

Just a very quick look through the files, here are some comments:

- snd_card_free() can't be called with NULL, but the error path in
  snd_cx18_init() may reach that (when snd_card_create() returns an

- Specifying both SNDRV_PCM_RATE_CONTINOUS and _KNOT to
  snd_pcm_hw_info.rates doesn't make sense.  In your case, if it's
  only 48kHz, SNDRV_PCM_RATE_48000 there instead.

- vfree() should be called in hw_free callback rather than close
  callback.  And, there are already global vmalloc-buffer helper
  functions in the latest ALSA tree for 2.6.34...

- It'd be nice if you give TLV information for the mixer dB mapping.


To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to
More majordomo info at

Reply via email to