Hi Enrico, Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.19-rc8 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Marco-Felsch/media-mt9m111-features/20181020-022716 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-x000-201841 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/media//i2c/mt9m111.c: In function 'mt9m111_probe': >> drivers/media//i2c/mt9m111.c:1185:9: error: implicit declaration of function >> 'mt9m111_probe_of'; did you mean 'mt9m111_probe'? >> [-Werror=implicit-function-declaration] ret = mt9m111_probe_of(client, mt9m111); ^~~~~~~~~~~~~~~~ mt9m111_probe cc1: some warnings being treated as errors vim +1185 drivers/media//i2c/mt9m111.c 1159 1160 static int mt9m111_probe(struct i2c_client *client, 1161 const struct i2c_device_id *did) 1162 { 1163 struct mt9m111 *mt9m111; 1164 struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); 1165 int ret; 1166 1167 if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA)) { 1168 dev_warn(&adapter->dev, 1169 "I2C-Adapter doesn't support I2C_FUNC_SMBUS_WORD\n"); 1170 return -EIO; 1171 } 1172 1173 mt9m111 = devm_kzalloc(&client->dev, sizeof(struct mt9m111), GFP_KERNEL); 1174 if (!mt9m111) 1175 return -ENOMEM; 1176 1177 mt9m111->clk = v4l2_clk_get(&client->dev, "mclk"); 1178 if (IS_ERR(mt9m111->clk)) 1179 return PTR_ERR(mt9m111->clk); 1180 1181 /* Default HIGHPOWER context */ 1182 mt9m111->ctx = &context_b; 1183 1184 if (IS_ENABLED(CONFIG_OF)) { > 1185 ret = mt9m111_probe_of(client, mt9m111); 1186 if (ret) 1187 return ret; 1188 } else { 1189 /* use default chip hardware values */ 1190 mt9m111->pclk_sample = 1; 1191 } 1192 1193 v4l2_i2c_subdev_init(&mt9m111->subdev, client, &mt9m111_subdev_ops); 1194 mt9m111->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; 1195 1196 v4l2_ctrl_handler_init(&mt9m111->hdl, 5); 1197 v4l2_ctrl_new_std(&mt9m111->hdl, &mt9m111_ctrl_ops, 1198 V4L2_CID_VFLIP, 0, 1, 1, 0); 1199 v4l2_ctrl_new_std(&mt9m111->hdl, &mt9m111_ctrl_ops, 1200 V4L2_CID_HFLIP, 0, 1, 1, 0); 1201 v4l2_ctrl_new_std(&mt9m111->hdl, &mt9m111_ctrl_ops, 1202 V4L2_CID_AUTO_WHITE_BALANCE, 0, 1, 1, 1); 1203 mt9m111->gain = v4l2_ctrl_new_std(&mt9m111->hdl, &mt9m111_ctrl_ops, 1204 V4L2_CID_GAIN, 0, 63 * 2 * 2, 1, 32); 1205 v4l2_ctrl_new_std_menu(&mt9m111->hdl, 1206 &mt9m111_ctrl_ops, V4L2_CID_EXPOSURE_AUTO, 1, 0, 1207 V4L2_EXPOSURE_AUTO); 1208 v4l2_ctrl_new_std_menu_items(&mt9m111->hdl, 1209 &mt9m111_ctrl_ops, V4L2_CID_TEST_PATTERN, 1210 ARRAY_SIZE(mt9m111_test_pattern_menu) - 1, 0, 0, 1211 mt9m111_test_pattern_menu); 1212 mt9m111->subdev.ctrl_handler = &mt9m111->hdl; 1213 if (mt9m111->hdl.error) { 1214 ret = mt9m111->hdl.error; 1215 goto out_clkput; 1216 } 1217 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
