2018年11月13日(火) 19:37 Sakari Ailus <sakari.ai...@linux.intel.com>:
>
> On Tue, Nov 13, 2018 at 01:00:50AM +0900, Akinobu Mita wrote:
> > The ov2640 has the test pattern generator features. This makes use of
> > it through V4L2_CID_TEST_PATTERN control.
> >
> > Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
> > Cc: Mauro Carvalho Chehab <mche...@kernel.org>
> > Signed-off-by: Akinobu Mita <akinobu.m...@gmail.com>
> > ---
> > drivers/media/i2c/ov2640.c | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c
> > index 20a8853..4992d77 100644
> > --- a/drivers/media/i2c/ov2640.c
> > +++ b/drivers/media/i2c/ov2640.c
> > @@ -705,6 +705,11 @@ static int ov2640_reset(struct i2c_client *client)
> > return ret;
> > }
> >
> > +static const char * const ov2640_test_pattern_menu[] = {
> > + "Disabled",
> > + "Color bar",
>
> s/b/B/
>
> The smiapp driver uses "Eight Vertical Colour Bars", not sure if that'd fit
> here or not. FYI.
This test pattern shows eight vertical color bars with blending actual
sensor image, although the datasheet tells just 'Color bar'.
So either is fine for me.
