On Mon, 2018-11-19 at 16:33 +0100, Hans Verkuil wrote: > Userspace shouldn't set bytesused to 0 for output buffers. > vb2_warn_zero_bytesused() warns about this (only once!), but it also > calls WARN_ON(1), which is confusing since it is not immediately clear > that it warns about a 0 value for bytesused. > > Just drop the WARN_ON as it serves no purpose. > > Signed-off-by: Hans Verkuil <[email protected]>
Acked-by: Ezequiel Garcia <[email protected]> > --- > diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c > b/drivers/media/common/videobuf2/videobuf2-v4l2.c > index a17033ab2c22..713326ef4e72 100644 > --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c > +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c > @@ -158,7 +158,6 @@ static void vb2_warn_zero_bytesused(struct vb2_buffer *vb) > return; > > check_once = true; > - WARN_ON(1); > > pr_warn("use of bytesused == 0 is deprecated and will be removed in the > future,\n"); > if (vb->vb2_queue->allow_zero_bytesused)
