Hi Luca, On Tue, Nov 27, 2018 at 09:34:43AM +0100, Luca Ceresoli wrote: > The V4L2_SUBDEV_FL_HAS_EVENTS flag should not be set, event are just > not implemented. > > Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
The driver supports controls, and so control events can be subscribed and received by the user. Therefore I don't see a reason to remove the flag. > --- > drivers/media/i2c/imx274.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c > index 95a0e7d9851a..78746c51071d 100644 > --- a/drivers/media/i2c/imx274.c > +++ b/drivers/media/i2c/imx274.c > @@ -1878,7 +1878,7 @@ static int imx274_probe(struct i2c_client *client, > imx274->client = client; > sd = &imx274->sd; > v4l2_i2c_subdev_init(sd, client, &imx274_subdev_ops); > - sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS; > + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > /* initialize subdev media pad */ > imx274->pad.flags = MEDIA_PAD_FL_SOURCE; -- Sakari Ailus sakari.ai...@linux.intel.com
