Hi Geert, On Sun, Jun 09, 2019 at 01:51:24PM +0200, Geert Uytterhoeven wrote: > On Sun, Jun 9, 2019 at 12:09 PM Laurent Pinchart wrote: > > On Sun, Jun 09, 2019 at 10:06:19AM +0200, Geert Uytterhoeven wrote: > > > On Sat, Jun 8, 2019 at 2:55 PM Laurent Pinchart wrote: > > > > This helps identifying the IP core version, for debugging purpose only > > > > for now. > > > > > > > > Signed-off-by: Laurent Pinchart > > > > <[email protected]> > > > > > > Thanks for your patch! > > > > > > > --- a/drivers/media/platform/rcar-fcp.c > > > > +++ b/drivers/media/platform/rcar-fcp.c > > > > > + if (IS_ERR(fcp->iomem)) > > > > + return PTR_ERR(fcp->iomem); > > > > + > > > > + pm_runtime_get_sync(&pdev->dev); > > > > + version = rcar_fcp_read(fcp, FCP_VCR); > > > > > > Please note that rcar_fcp_read() does not exist in upstream nor next, > > > and linux-renesas-soc hasn't seen the patch that added it. > > > > That's why it was added in this patch :-) > > Bummer... Do you plan to have other users? > If not, I'd just open-code this single-line function.
Yes, with FNCL support there should be other users. -- Regards, Laurent Pinchart
