On Wed, Jul 17, 2019 at 08:11:50PM +0200, Jan Pieter van Woerkom wrote:
> The T230C v2 hardware needs a mode of the si2168 chip to be
> set for which the si2168 driver previously had no support.
> This patch uses a specific measure to configure this on the
> T230C v2 hardware only - see the flag passed via the ts_mode
> attribute and its dependency on USB_PID_MYGICA_T230C2.
>
> Signed-off-by: Jan Pieter van Woerkom <j...@jpvw.nl>
> Tested-by: Frank Rysanek <frantisek.rysa...@post.cz>
> ---
> diff -ru a/drivers/media/dvb-frontends/si2168.c
> b/drivers/media/dvb-frontends/si2168.c
> --- a/drivers/media/dvb-frontends/si2168.c 2019-07-08 00:41:56.000000000
> +0200
> +++ b/drivers/media/dvb-frontends/si2168.c 2019-07-16 21:21:39.267802750
> +0200
> @@ -82,8 +82,18 @@
>
> dev_dbg(&client->dev, "%s acquire: %d\n", __func__, acquire);
>
> + /* set manual value */
> + if (dev->ts_mode & SI2168_TS_CLK_MANUAL) {
> + memcpy(cmd.args, "\x14\x00\x0d\x10\xe8\x03", 6);
> + cmd.wlen = 6;
> + cmd.rlen = 4;
> + ret = si2168_cmd_execute(client, &cmd);
> + if (ret)
> + return ret;
> + }
> /* set TS_MODE property */
> memcpy(cmd.args, "\x14\x00\x01\x10\x10\x00", 6);
> + cmd.args[4] <<= (dev->ts_mode & SI2168_TS_CLK_MANUAL) >> 5;
I'm sorry but this is not very readable. How about:
if (dev->ts_mode & SI2168_TS_CLK_MANUAL)
cmd.args[4] = SI2168_TS_CLK_MANUAL;
?
Sean
> if (acquire)
> cmd.args[4] |= dev->ts_mode;
> else
> diff -ru a/drivers/media/dvb-frontends/si2168.h
> b/drivers/media/dvb-frontends/si2168.h
> --- a/drivers/media/dvb-frontends/si2168.h 2019-07-08 00:41:56.000000000
> +0200
> +++ b/drivers/media/dvb-frontends/si2168.h 2019-07-16 06:29:53.913009262
> +0200
> @@ -30,6 +30,7 @@
> #define SI2168_TS_PARALLEL 0x06
> #define SI2168_TS_SERIAL 0x03
> #define SI2168_TS_TRISTATE 0x00
> +#define SI2168_TS_CLK_MANUAL 0x20
> u8 ts_mode;
>
> /* TS clock inverted */
