Hi Shawn,

On Wed, Aug 07, 2019 at 06:07:56PM +0800, Shawnx Tu wrote:
> From: Shawn Tu <shawnx...@intel.com>
> 
> Add a V4L2 sub-device driver for Omnivision ov5675 image sensor.
> This is a camera sensor using the I2C bus for control and the
> CSI-2 bus for data.
> 
> This driver supports following features:
> - manual exposure and analog/digital gain control support
> - vblank/hblank control support
> - test pattern support
> - media controller support
> - runtime PM support
> - support following resolutions:
>   + 2592x1944 at 30FPS
>   + 1296x972  at 30FPS
> 
> Signed-off-by: Shawn Tu <shawnx...@intel.com>

Applied, with the following diff (was over 80 characters per line):

diff --git a/drivers/media/i2c/ov5675.c b/drivers/media/i2c/ov5675.c
index a35b9fb8b908..81593aebf262 100644
--- a/drivers/media/i2c/ov5675.c
+++ b/drivers/media/i2c/ov5675.c
@@ -646,7 +646,8 @@ static int ov5675_set_ctrl(struct v4l2_ctrl *ctrl)
        case V4L2_CID_VBLANK:
                ret = ov5675_write_reg(ov5675, OV5675_REG_VTS,
                                       OV5675_REG_VALUE_16BIT,
-                                      ov5675->cur_mode->height + ctrl->val + 
10);
+                                      ov5675->cur_mode->height + ctrl->val +
+                                      10);
                break;
 
        case V4L2_CID_TEST_PATTERN:
@@ -710,7 +711,8 @@ static int ov5675_init_controls(struct ov5675 *ov5675)
        v4l2_ctrl_new_std(ctrl_hdlr, &ov5675_ctrl_ops, V4L2_CID_DIGITAL_GAIN,
                          OV5675_DGTL_GAIN_MIN, OV5675_DGTL_GAIN_MAX,
                          OV5675_DGTL_GAIN_STEP, OV5675_DGTL_GAIN_DEFAULT);
-       exposure_max = (ov5675->cur_mode->vts_def - 
OV5675_EXPOSURE_MAX_MARGIN)/2;
+       exposure_max = (ov5675->cur_mode->vts_def -
+                       OV5675_EXPOSURE_MAX_MARGIN) / 2;
        ov5675->exposure = v4l2_ctrl_new_std(ctrl_hdlr, &ov5675_ctrl_ops,
                                             V4L2_CID_EXPOSURE,
                                             OV5675_EXPOSURE_MIN, exposure_max,


-- 
Sakari Ailus
sakari.ai...@linux.intel.com

Reply via email to