On Wed, 2019-09-25 at 11:40 -0700, Kees Cook wrote: > On Wed, Sep 25, 2019 at 10:13:37AM -0700, Joe Perches wrote: > > On Thu, 2019-09-19 at 09:56 +0300, Dan Carpenter wrote: > > > When I sent a patch, I use get_maintainer.pl then I add whoever the > > > wrote the commit from the Fixes tag. Then I remove Colin King and Kees > > > Cook from the CC list because they worked all over the tree and I know > > > them. I also normally remove LKML if there is another mailing list but > > > at least one subsystem uses LKML for patchwork so this isn't safe. > > > > > > So the safest instructions are "Use get_matainer.pl and add the person > > > who wrote the commit in the Fixes tag". > > > > Maybe add this: > > > > Add the signers of any commit referenced in a "Fixes: <commit>" line > > of a patch description. > > Oh yes please! I've always done this manually, so that's a nice bit of > automation. :) > > Is "6" a safe lower bound here? I thought 12 was the way to go? [] > $ git log | egrep 'Fixes: [a-f0-9]{1,40}' | col2 | awk '{print length }' | > sort | uniq -c | sort -n | tail > 238 8 > 300 7 > 330 14 > 344 6 > 352 11 > 408 40 > 425 10 > 735 16 > 1866 13 > 31446 12 > > Hmpf, 6 is pretty high up there...
Yes, but your grep then col2 isn't right. You are counting all the 'Fixes: commit <foo>' output as 6 because that's the length of 'commit'. I also think the length of the hex commit value doesn't matter much as it's got to be a specific single commit SHA1 anyway, otherwise the commit id lookup will fail. > > > @@ -1031,6 +1040,7 @@ MAINTAINER field selection options: > > --roles => show roles (status:subsystem, git-signer, list, etc...) > > --rolestats => show roles and statistics (commits/total_commits, %) > > --file-emails => add email addresses found in -f file (default: 0 > > (off)) > > + --fixes => for patches, add signatures of commits with 'Fixes: > > <commit>' (default: 1 (on)) > > Should "Tested-by" and "Co-developed-by" get added to @signature_tags ? All "<foo>-by:" signatures are added. > @commit_authors is unused? Yes, authors are already required to sign-off so it's just duplicating already existing signatures.