On Fri, Oct 11, 2019 at 7:56 AM Boris Brezillon <boris.brezil...@collabora.com> wrote: > > On Fri, 11 Oct 2019 07:50:16 -0500 > Rob Herring <robh...@kernel.org> wrote: > > > On Fri, Oct 11, 2019 at 4:33 AM Boris Brezillon > > <boris.brezil...@collabora.com> wrote: > > > > > > Document the Rockchip RK3399 Video Decoder bindings. > > > > You need some more headers for the example (or drop defines): > > > > Error: > > Documentation/devicetree/bindings/media/rockchip,vdec.example.dts:23.28-29 > > syntax error > > FATAL ERROR: Unable to parse input tree > > scripts/Makefile.lib:321: recipe for target > > 'Documentation/devicetree/bindings/media/rockchip,vdec.example.dt.yaml' > > failed > > make: *** > > [Documentation/devicetree/bindings/media/rockchip,vdec.example.dt.yaml] > > Error 1 > > Makefile:1282: recipe for target 'dt_binding_check' failed > > make: *** [dt_binding_check] Error 2 > > Will fix that. BTW, I tried running make dtbs_check and faced a few > errors on other yaml files (which is why I ended up sending the patch > without fully validating the schema). Maybe those have been fixed (I'm > based on the media tree which is based on 5.4-rc1).
Several fixes went into -rc2, but there's 2 fixes not in -rc2 (but are in next). > Oh, and I also noticed that the generated example has > #address-cells = <1>, #size-cells = <1> in the parent node, while my > example expects <2>. Is there any way I can specify that somewhere, or > should I just tweak the example to use 1 cell instead? I think you can override it just adding '#address-cells = <2>;' or tweak the example. Rob