Destroy the mutex initialised by the driver in probe.

Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
---
 drivers/media/i2c/smiapp/smiapp-core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/smiapp/smiapp-core.c 
b/drivers/media/i2c/smiapp/smiapp-core.c
index 24f4197cf7ad..1756c9e640b5 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -2854,7 +2854,6 @@ static int smiapp_probe(struct i2c_client *client)
                return -ENOMEM;
 
        sensor->hwcfg = hwcfg;
-       mutex_init(&sensor->mutex);
        sensor->src = &sensor->ssds[sensor->ssds_used];
 
        v4l2_i2c_subdev_init(&sensor->src->sd, client, &smiapp_ops);
@@ -2918,6 +2917,8 @@ static int smiapp_probe(struct i2c_client *client)
        if (rval < 0)
                return rval;
 
+       mutex_init(&sensor->mutex);
+
        rval = smiapp_identify_module(sensor);
        if (rval) {
                rval = -ENODEV;
@@ -3111,6 +3112,7 @@ static int smiapp_probe(struct i2c_client *client)
 
 out_power_off:
        smiapp_power_off(&client->dev);
+       mutex_destroy(&sensor->mutex);
 
        return rval;
 }
@@ -3133,6 +3135,7 @@ static int smiapp_remove(struct i2c_client *client)
                media_entity_cleanup(&sensor->ssds[i].sd.entity);
        }
        smiapp_cleanup(sensor);
+       mutex_destroy(&sensor->mutex);
 
        return 0;
 }
-- 
2.20.1

Reply via email to