Hi Richard,
On Fri, Jan 16, 2026 at 11:06:53PM -0500, Richard Acayan wrote:
> The IMX355 camera sensor is a camera sensor that can be found as the
> front camera in some smartphones, such as the Pixel 3, Pixel 3 XL, Pixel
> 3a, and Pixel 3a XL. It already has a driver, but needs support for
> device tree. Document the IMX355 to support defining it in device tree.
>
> Reviewed-by: Vladimir Zapolskiy <[email protected]>
> Signed-off-by: Richard Acayan <[email protected]>
> ---
> .../bindings/media/i2c/sony,imx355.yaml | 105 ++++++++++++++++++
> 1 file changed, 105 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml
> b/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml
> new file mode 100644
> index 000000000000..0a3aa63b7b5f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/sony,imx355.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony IMX355 Sensor
> +
> +maintainers:
> + - Richard Acayan <[email protected]>
> +
> +description:
> + The IMX355 sensor is a 3280x2464 image sensor, commonly found as the front
> + camera in smartphones.
> +
> +allOf:
> + - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> + compatible:
> + const: sony,imx355
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + avdd-supply:
> + description: Analog power supply.
> +
> + dvdd-supply:
> + description: Digital power supply.
> +
> + dovdd-supply:
> + description: Interface power supply.
> +
> + reset-gpios:
> + description: Reset GPIO (active low).
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml
> + unevaluatedProperties: false
Can you add data-lanes property with the default of 4? That's what the
driver uses and can't do anything else right now -- the driver should
actually fail if the number of lanes differs; a patch to do that would be
nice.
> +
> + required:
> + - link-frequencies
> +
> + required:
> + - endpoint
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - avdd-supply
> + - dvdd-supply
> + - dovdd-supply
> + - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,camcc-sdm845.h>
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@1a {
> + compatible = "sony,imx355";
> + reg = <0x1a>;
> +
> + clocks = <&camcc CAM_CC_MCLK2_CLK>;
> +
> + assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>;
> + assigned-clock-rates = <24000000>;
> +
> + reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>;
> +
> + avdd-supply = <&cam_front_ldo>;
> + dvdd-supply = <&cam_front_ldo>;
> + dovdd-supply = <&cam_vio_ldo>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&cam_front_default>;
> +
> + rotation = <270>;
> + orientation = <0>;
> +
> + port {
> + cam_front_endpoint: endpoint {
> + link-frequencies = /bits/ 64 <360000000>;
> + remote-endpoint = <&camss_endpoint1>;
> + };
> + };
> + };
> + };
--
Kind regards,
Sakari Ailus
