> -----Original Message----- > From: Hans Verkuil [mailto:[email protected]] > Sent: Sunday, May 09, 2010 7:27 PM > To: [email protected] > Cc: Hiremath, Vaibhav > Subject: [PATCH 1/6] [RFC] tvp514x: do NOT change the std as a side effect > > Several calls (try_fmt, g_parm among others) changed the current standard > as a side effect of that call. But the standard may only be changed by > s_std. > > Signed-off-by: Hans Verkuil <[email protected]> > --- > drivers/media/video/tvp514x.c | 53 ++++++++++++-------------------------- > -- > 1 files changed, 16 insertions(+), 37 deletions(-) > <snip> > - decoder->current_std = current_std; > + current_std = decoder->current_std; > > *timeperframe = > decoder->std_list[current_std].standard.frameperiod; > -- > 1.6.4.2
[Hiremath, Vaibhav] Looks ok to me. I have tested it on AM3517EVM platform. Reviewed-by: Vaibhav Hiremath <[email protected]> Tested-by: Vaibhav Hiremath <[email protected]> Acked-by: Vaibhav Hiremath <[email protected]> Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
