On Wednesday 19 May 2010 18:44:32 [email protected] wrote:
> From: Asheesh Bhardwaj <[email protected]>
>
> ---
> drivers/media/video/davinci/vpif_display.c | 59
> ++++++++++++++++++++++++++++
> drivers/media/video/davinci/vpif_display.h | 1 +
> 2 files changed, 60 insertions(+), 0 deletions(-)
Hi Asheesh,
This is a general comment for this patch series: I think these drivers are
in need of some comments in the code describing these buffer module options
and how to use them.
Or perhaps instead of comments there should be a document in the
Documentation/video4linux directory. Although comments have the advantage of
being more likely to be kept up to date.
You should also run checkpatch.pl over your patches: I saw several coding style
violations.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
