videobuf_dvb_register_bus() returns negative error codes on failure.  This
was introduced in e4425eab6b2: "V4L/DVB: cx23885: Check register errors".

Signed-off-by: Dan Carpenter <erro...@gmail.com>
---
I don't have the hardware to test this, but it looks reversed.

diff --git a/drivers/media/video/cx23885/cx23885-dvb.c 
b/drivers/media/video/cx23885/cx23885-dvb.c
index 0a199d7..bf7c328 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -991,7 +991,7 @@ static int dvb_register(struct cx23885_tsport *port)
        ret = videobuf_dvb_register_bus(&port->frontends, THIS_MODULE, port,
                                        &dev->pci->dev, adapter_nr, 0,
                                        cx23885_dvb_fe_ioctl_override);
-       if (!ret)
+       if (ret < 0)
                return ret;
 
        /* init CI & MAC */
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to