On Sun, Jun 20, 2010 at 12:44 PM, Stefan Ringel <stefan.rin...@arcor.de> wrote: > Am 20.06.2010 18:31, schrieb Jarod Wilson: >> On Sun, Jun 20, 2010 at 11:38 AM, <stefan.rin...@arcor.de> wrote: >>> From: Stefan Ringel <stefan.rin...@arcor.de> >>> >>> Signed-off-by: Stefan Ringel <stefan.rin...@arcor.de> >>> --- >>> drivers/staging/tm6000/Makefile | 3 +- >>> drivers/staging/tm6000/tm6000-cards.c | 27 +++- >>> drivers/staging/tm6000/tm6000-input.c | 357 > +++++++++++++++++++++++++++++++++ >>> drivers/staging/tm6000/tm6000.h | 11 + >>> 4 files changed, 396 insertions(+), 2 deletions(-) >>> create mode 100644 drivers/staging/tm6000/tm6000-input.c >> ... >>> diff --git a/drivers/staging/tm6000/tm6000-input.c > b/drivers/staging/tm6000/tm6000-input.c >>> new file mode 100644 >>> index 0000000..e45b443 >>> --- /dev/null >>> +++ b/drivers/staging/tm6000/tm6000-input.c >>> @@ -0,0 +1,357 @@ >>> +/* >>> + tm6000-input.c - driver for TM5600/TM6000/TM6010 USB video capture > devices >>> + >>> + Copyright (C) 2010 Stefan Ringel <stefan.rin...@arcor.de> >>> + >>> + This program is free software; you can redistribute it and/or modify >>> + it under the terms of the GNU General Public License as published by >>> + the Free Software Foundation version 2 >>> + >>> + This program is distributed in the hope that it will be useful, >>> + but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + GNU General Public License for more details. >>> + >>> + You should have received a copy of the GNU General Public License >>> + along with this program; if not, write to the Free Software >>> + Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. >>> + */ >>> + >>> +#include <linux/module.h> >>> +#include <linux/init.h> >>> +#include <linux/delay.h> >>> + >>> +#include <linux/input.h> >>> +#include <linux/usb.h> >>> + >>> +#include "compat.h" >>> +#include "tm6000.h" >>> +#include "tm6000-regs.h" >> >> Please use the new ir-core infrastructure here. (#include >> <media/ir-core.h>, #include <media/rc-map.h>, and assorted code in >> drivers/media/IR/). >> >> > It use the new code (for example rc map in tm6000-card.c), but I can > added the header files. It doesn't use software encoding, it use > hardware encodeing.
It only partially uses it. You're setting up input_dev's directly and still using ir_input_state. You should be using the ir_input_dev functions. Hardware decoder vs. software decoder doesn't matter. See drivers/media/IR/imon.c for another hardware decoding device that's using ir_input_dev. :) -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
