On Wed, Sep 8, 2010 at 5:42 PM, David Härdeman <da...@hardeman.nu> wrote: > On Wed, Sep 08, 2010 at 10:42:10AM -0300, Mauro Carvalho Chehab wrote: >> Em 07-09-2010 18:51, David Härdeman escreveu: >> > This patch merges the files which makes up ir-core and renames the >> > resulting module to rc-core. IMHO this makes it much easier to hack >> > on the core module since all code is in one file. >> > >> > This also allows some simplification of ir-core-priv.h as fewer internal >> > functions need to be exposed. >> >> I'm not sure about this patch. Big files tend to be harder to maintain, >> as it takes more time to find the right functions inside it. Also, IMO, >> it makes sense to keep the raw-event code on a separate file. > > I don't find "big" files difficult (note: we're talking about 1300 lines > here). Rather the opposite, no hesitation about which files a given > function originates from and all related code in one nice file. evdev.c > and input.c are good precedents. But of course, it all boils down to a > matter of personal taste.
I think I have to finally admit that my personal taste tends toward one "big" file in this particular case. >> Anyway, if we apply this patch right now, it will cause merge conflicts with >> the input tree, due to the get/setkeycodebig patches, and with some other >> patches that are pending merge/review. The better is to apply such patch >> just after the release of 2.6.37-rc1, after having all those conflicts >> solved. > > I agree that the big scancode patches from the input tree should go > first. I keep updating my patchset as the media_tree (staging/v2.6.37 > branch) changes so I have no problem sending an updated patchset at a > suitable time in the future. Please feel free to add this to the subsequent refreshes: Acked-by: Jarod Wilson <ja...@redhat.com> -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
