On Fri, 2010-09-24 at 15:09 +0200, ext Hans Verkuil wrote:
> > This driver implements V4L2 controls for the Texas Instruments
> > WL1273 FM Radio.
> >
> > Signed-off-by: Matti J. Aaltonen <matti.j.aalto...@nokia.com>
> > ---
> > drivers/media/radio/Kconfig | 15 +
> > drivers/media/radio/Makefile | 1 +
> > drivers/media/radio/radio-wl1273.c | 1859
> > ++++++++++++++++++++++++++++++++++++
> > drivers/mfd/Kconfig | 5 +
> > drivers/mfd/Makefile | 2 +
> > 5 files changed, 1882 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/media/radio/radio-wl1273.c
> >
> > +static int wl1273_fm_vidioc_querycap(struct file *file, void *priv,
> > + struct v4l2_capability *capability)
> > +{
> > + struct wl1273_device *radio = video_get_drvdata(video_devdata(file));
> > +
> > + dev_dbg(radio->dev, "%s\n", __func__);
> > +
> > + strlcpy(capability->driver, WL1273_FM_DRIVER_NAME,
> > + sizeof(capability->driver));
> > + strlcpy(capability->card, "Texas Instruments Wl1273 FM Radio",
> > + sizeof(capability->card));
> > + strlcpy(capability->bus_info, "I2C", sizeof(capability->bus_info));
> > +
> > + capability->capabilities = V4L2_CAP_HW_FREQ_SEEK |
> > + V4L2_CAP_TUNER | V4L2_CAP_RADIO | V4L2_CAP_AUDIO |
> > + V4L2_CAP_RDS_CAPTURE | V4L2_CAP_MODULATOR |
> > + V4L2_CAP_RDS_OUTPUT | V4L2_TUNER_CAP_RDS_BLOCK_IO;
> > +
> > + return 0;
> > +}
>
> V4L2_TUNER_CAP_RDS_BLOCK_IO is a tuner/modulator capability! Not a
> querycap capability! It's added at the wrong place.
Alright... I'll fix that in v11...
Thanks,
Matti
>
> Regards,
>
> Hans
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
