Hi Mauro, On Thursday 07 October 2010 14:45:43 Mauro Carvalho Chehab wrote: > As pointed by Laurent: > > I think min_t(size_t, PAGE_SIZE, size) is the preferred way. > > Thanks-to: Laurent Pinchart <[email protected]> > Signed-off-by: Mauro Carvalho Chehab <[email protected]> > > diff --git a/drivers/media/video/videobuf-dma-sg.c > b/drivers/media/video/videobuf-dma-sg.c index 7153e44..20f227e 100644 > --- a/drivers/media/video/videobuf-dma-sg.c > +++ b/drivers/media/video/videobuf-dma-sg.c > @@ -116,8 +116,8 @@ static struct scatterlist *videobuf_pages_to_sg(struct > page **pages, goto nopage; > if (PageHighMem(pages[i])) > goto highmem; > - sg_set_page(&sglist[i], pages[i], min((unsigned)PAGE_SIZE, > size), 0); > - size -= min((unsigned)PAGE_SIZE, size); > + sg_set_page(&sglist[i], pages[i], min_t(size_t, PAGE_SIZE, > size), 0);
This won't pass checkpatch.pl (line > 80 characters long). Beside, this patch applies on top of the previous one whereas I suppose you'd want to replace the previous one. > + size -= min_t(size_t, PAGE_SIZE, size); > } > return sglist; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
