Hi Hans, On Thursday 25 November 2010 12:23:18 Hans Verkuil wrote: > On Thursday, November 25, 2010 10:48:39 Marek Szyprowski wrote: > > On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: > > > On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: > > > > From: Pawel Osciak <p.osc...@samsung.com>
[snip] > > > > + * @plane_setup: called before memory allocation num_planes > > > > times; > > > > + * driver should return the required size of plane > > > > number > > > > + * plane_no > > > > + * @unlock: release any locks taken while calling vb2 > > > > functions; > > > > + * it is called before poll_wait function in > > > > vb2_poll > > > > + * implementation; required to avoid deadlock when > > > > vb2_poll > > > > + * function waits for a buffer > > > > + * @lock: reacquire all locks released in the previous > > > > callback; > > > > + * required to continue operation after sleeping in > > > > + * poll_wait function > > > > > > Those names were not very clear to me at first sight. What about > > > renaming those two operations poll_prepare and poll_finish (or > > > similar) ? Feel free to disagree here, I'm not sure what I would > > > prefer, but I thought I would throw the idea in. > > > > I see your point here but I'm not sure it will make the code easier to > > understand. Hans - could you comment on this? > > I think I agree with Laurent, although I think I would prefer to have it > called wait_prepare and wait_finish. Better alternatives are welcome :-) I agree with those names. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
