Hello.

Manjunath Hadli wrote:

Implemented a common and single mapping for DAVINCI_SYSTEM_MODULE_BASE
to be used by all davinci platforms.

Signed-off-by: Manjunath Hadli <[email protected]>
Acked-by: Muralidharan Karicheri <[email protected]>
Acked-by: Hans Verkuil <[email protected]>
[...]

diff --git a/arch/arm/mach-davinci/common.c b/arch/arm/mach-davinci/common.c
index 1d25573..fa7152d 100644
--- a/arch/arm/mach-davinci/common.c
+++ b/arch/arm/mach-davinci/common.c
@@ -111,7 +111,9 @@ void __init davinci_common_init(struct davinci_soc_info 
*soc_info)
                if (ret != 0)
                        goto err;
        }
-
+       davinci_sysmodbase = ioremap_nocache(DAVINCI_SYSTEM_MODULE_BASE, 0x800);
+       if (!davinci_sysmodbase)
+               return;

This seems pointless check as you'll return anyway. You should probably 'goto err', not 'return' here.

        return;
err:

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to