On Wed, Mar 16, 2011 at 08:07:22PM -0400, Andy Walls wrote: > On Wed, 2011-03-16 at 16:24 -0400, Jarod Wilson wrote: > > Signed-off-by: Jarod Wilson <[email protected]> > > --- > > drivers/staging/lirc/lirc_zilog.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/staging/lirc/lirc_zilog.c > > b/drivers/staging/lirc/lirc_zilog.c > > index 407d4b4..5ada643 100644 > > --- a/drivers/staging/lirc/lirc_zilog.c > > +++ b/drivers/staging/lirc/lirc_zilog.c > > @@ -950,6 +950,10 @@ static ssize_t read(struct file *filep, char *outbuf, > > size_t n, loff_t *ppos) > > ret = copy_to_user((void *)outbuf+written, buf, > > rbuf->chunk_size); > > written += rbuf->chunk_size; > > + } else { > > + zilog_error("Buffer read failed!\n"); > > + ret = -EIO; > > + break; > > No need to break, just let the non-0 ret value drop you out of the while > loop.
Ah, indeed. I think I mindlessly copied what the tests just a few lines above were doing without looking at the actual reason for them. I'll remove that break from the patch here locally. -- Jarod Wilson [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
