Hi Sylwester, On Thursday 24 March 2011 15:58:02 Sylwester Nawrocki wrote: > On 03/24/2011 03:38 PM, Laurent Pinchart wrote: > > On Thursday 24 March 2011 15:19:54 Sylwester Nawrocki wrote: > >> Add V4L2_MBUS_FMT_JPEG_1X8 format and the corresponding Docbook > >> documentation. > >> > >> Signed-off-by: Sylwester Nawrocki <s.nawro...@samsung.com> > >> Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> > >> --- > >> > >> Hi all, > >> > >> I would like to propose and addition of JPEG format to the list > >> of media bus formats. The requirement of this format had already > >> been discussed in the past [1], [2]. > >> This patch adds relevant entry in v4l2-mediabus.h header and > >> the documentation. Initially I have added only bus width information > >> to the format code. I am not sure what other information could be > >> included. I am open to suggestions if anyone knows about any other > >> requirements. > >> > >> JPEG format on media bus is, among others, required for Samsung > >> S5P MIPI CSI receiver [3] and M-5MOLS camera drivers [4]. > >> > >> Comments are welcome! > >> > >> -- > >> Regards, > >> Sylwester Nawrocki, > >> Samsung Poland R&D Center > >> > >> [1] http://www.spinics.net/lists/linux-media/msg27980.html > >> [2] http://www.spinics.net/lists/linux-media/msg28651.html > >> [3] http://www.spinics.net/lists/linux-samsung-soc/msg03807.html > >> [4] http://lwn.net/Articles/433836/ > >> --- > >> > >> Documentation/DocBook/v4l/subdev-formats.xml | 45 > >> > >> ++++++++++++++++++++++++++ include/linux/v4l2-mediabus.h > >> | > >> > >> 3 ++ > >> > >> 2 files changed, 48 insertions(+), 0 deletions(-) > >> > >> diff --git a/Documentation/DocBook/v4l/subdev-formats.xml > >> b/Documentation/DocBook/v4l/subdev-formats.xml index b5376e2..60a6fe2 > >> 100644 > >> --- a/Documentation/DocBook/v4l/subdev-formats.xml > >> +++ b/Documentation/DocBook/v4l/subdev-formats.xml > >> @@ -2463,5 +2463,50 @@ > >> > >> </tgroup> > >> > >> </table> > >> > >> </section> > >> > >> + > >> + <section> > >> + <title>JPEG Compressed Formats</title> > >> + > >> + <para>Those data formats are used to transfer arbitrary > >> byte-based image + data obtained from JPEG compression process. The > >> format code + is made of the following information. > >> + <itemizedlist> > >> + <listitem>The bus width in bits.</listitem> > >> + </itemizedlist> > >> + > >> + <para>For instance, a format where bus width is 8 bits will be named > >> + <constant>V4L2_MBUS_FMT_JPEG_1X8</constant>. > >> + </para> > >> + > >> + </para> > >> + > >> + <para>The following table lists existing JPEG compressed > >> formats.</para> + > >> + <table pgwide="0" frame="none" id="v4l2-mbus-pixelcode-jpeg"> > >> + <title>JPEG Formats</title> > >> + <tgroup cols="23"> > > Oops, looks like I've send wrong patch version. That should read > > <tgroup cols="3"> > > >> + <colspec colname="id" align="left" /> > >> + <colspec colname="code" align="left"/> > >> + <colspec colname="remarks" align="left"/> > >> + <thead> > >> + <row> > >> + <entry>Identifier</entry> > >> + <entry>Code</entry> > >> + <entry>Remarks</entry> > >> + </row> > >> + </thead> > >> + <tbody valign="top"> > >> + <row id="V4L2-MBUS-FMT-JPEG-1X8"> > >> + <entry>V4L2_MBUS_FMT_JPEG_1X8</entry> > >> + <entry>0x4001</entry> > >> + <entry> This format shall be used for of transmission of JPEG > > ..and s/for of/for > > >> + data over MIPI CSI-2 bus with User Defined 8-bit Data types. > > > > JPEG formats are not limited to MIPI, some parallel sensors can transmit > > JPEG as well. > > Yes, I am aware of that. One of examples could be the old TCM8240MD sensor. > http://www.sparkfun.com/datasheets/Sensors/Imaging/TCM8240MD_E150405_REV13. > pdf > > My intention was to indicate that V4L2_MBUS_FMT_JPEG_1X8 format is > the preferred one for "User Defined 8-bit Data Transmission" over > the serial MIPI-CSI link. > > I'm not sure if "Remarks" column is needed. > > Maybe something like: > ... > + <entry>0x4001</entry> > + <entry> This format is recommended for transmission of JPEG > + data over MIPI CSI-2 bus with User Defined 8-bit Data types. > + <entry> > ... > > would be better?
Yes that's better. Your first version sounded like the format was only used for MIPI CSI-2 sensors to me. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
