On Fri, Apr 29, 2011 at 5:51 AM, Mauro Carvalho Chehab <mche...@redhat.com> wrote: > Hi Sean, > > Em 21-02-2011 18:49, Sean Young escreveu: >> I have a SheevaPlug which has no (human) input or output devices, with a >> DVB USB device connected with a mythtv backend running. The DVB USB drivers >> pull in the remote control tree, which is unneeded in this case; the >> mythtv client runs elsewhere (where RC is used). However the RC tree depends >> on input which also has dependants. >> >> This can save a reasonable amount of memory: >> >> $ ./scripts/bloat-o-meter vmlinux vmlinux-no-rc add/remove: 0/909 >> grow/shrink: 1/20 up/down: 4/-159171 (-159167) > > Sorry for a late review. The problem with this patch is that it is too much > intrusive. > It is a bad practice to fill the code with lots of #ifdef's, because it makes > harder > to analyse the source code and find bugs there. > > Also, while it saves some memory, this strategy forces that all DVB drivers > to have a > check for RC_CORE, being very easy that someone would forget about that, > causing compilation > breakages if this option is disabled. > > The proper way is to have a separate module for RC and just making such > module as dependent > of RC_CORE.
Sean, could you possibly rework your patch in accordance with what Mauro stated above? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
