Hi Russell,
On Wednesday 18 May 2011 01:08:21 Russell King - ARM Linux wrote:
> On Tue, May 17, 2011 at 11:28:48AM +0200, Javier Martin wrote:
> > +#include "devices.h"
> > +#include "../../../drivers/media/video/omap3isp/isp.h"
> > +#include "../../../drivers/media/video/omap3isp/ispreg.h"
>
> This suggests that there's something very wrong with what's going on;
> it suggests that you're trying to access driver internals which should
> be handled via some better means. And it looks like it's this:
> > @@ -654,6 +715,62 @@ static void __init beagle_opp_init(void)
> >
> > return;
> >
> > }
> >
> > +extern struct platform_device omap3isp_device;
> > +
> > +static int beagle_cam_set_xclk(struct v4l2_subdev *subdev, int hz)
> > +{
> > + struct isp_device *isp = platform_get_drvdata(&omap3isp_device);
> > + int ret;
> > +
> > + ret = isp->platform_cb.set_xclk(isp, hz, MT9P031_XCLK);
> > + return 0;
> > +}
>
> That really needs fixing in a different way.
I plan to look into whether I can expose the OMAP3 ISP clocks through the
Linux clock framework.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
