On Thu, 2 Jun 2011, javier Martin wrote:

> OK Guennadi,
> I'll fix those cosmetics issues in my next version where I will add
> VFLIP and HFLIP control support (which I removed previously to make
> the code less complex).

Please, don't. Let's first get the simple version of your driver in the 
mainline, then it can be extended. Just, please, make sure to address all 
remaining issues without changing anything else:)

Thanks
Guennadi

> 
> Now we talk about controls I have a question regarding controls
> defined in video subdevices like mt9p031 or mt9v032:
> 
> What device node should I use to set these controls through an ioctl() ?
> For instance, with mt9p031 + Beagleboard xM we have:
> 
> ./media-ctl -r -l '"mt9p031 2-0048":0->"OMAP3 ISP CCDC":0[1], "OMAP3
> ISP CCDC":1->"OMAP3 ISP CCDC output":0[1]'
> ./media-ctl -f '"mt9p031 2-0048":0[SGRBG12 320x240], "OMAP3 ISP
> CCDC":0[SGRBG8 320x240], "OMAP3 ISP CCDC":1[SGRBG8 320x240]'
> ./yavta --stdout -f SGRBG8 -s 320x240 -n 4 --capture=100 --skip 3 -F
> `./media-ctl -e "OMAP3 ISP CCDC output"` | nc 192.168.0.42 3000
> 
> Where
> 
> root@beagleboard:~# ./media-ctl -e "OMAP3 ISP CCDC output"
> /dev/video2
> 
> However, if I try to set sensor controls using /dev/video2 I get an
> error (invalid argument).
> 
> -- 
> Javier Martin
> Vista Silicon S.L.
> CDTUC - FASE C - Oficina S-345
> Avda de los Castros s/n
> 39005- Santander. Cantabria. Spain
> +34 942 25 32 60
> www.vista-silicon.com
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to