On Sat, 6 Aug 2011, Sakari Ailus wrote:

[snip]

> > +
> > +           /*
> > +            * q->num_buffers contains the total number of buffers, that the
> > +            * queue driver has set up
> > +            */
> > +           ret = call_qop(q, queue_setup, q, &num_buffers,
> > +                          &num_planes, create->sizes, q->alloc_ctx);
> > +
> > +           if (!ret && allocated_buffers < num_buffers)
> > +                   ret = -ENOMEM;
> 
> Is this really an error?

It is. See the current REQBUFS implementation

> How is the queue_setup op expected to change
> num_buffers, and why?

At this stage it should accept the proposed smaller number of buffers, because 
that's all we managed to allocate.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to