Hi Hans, > While going through the compile warnings generated in the daily build I > came > across this one: > > v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c: In function > 'si470x_int_in_callback': > v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c:398:16: warning: > variable 'buf' set but not used [-Wunused-but-set-variable] > > The 'unsigned char buf[RDS_REPORT_SIZE];' is indeed unused, but can I just > remove it? There is this single assignment to buf: 'buf[0] = RDS_REPORT;'. > > This makes me wonder if it is perhaps supposed to be used after all. > > Please let me know if I can remove it, or if it is a bug that someone needs > to fix.
this is an artifact from shifting the rds processing function into interrupt context. Yes, this can safely be removed. Can you do this? Bye, Toby -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
