Hi Sakari, On 12/30/2011 10:42 PM, Sakari Ailus wrote: > Hi Sylwester, > > On Tue, Dec 27, 2011 at 08:43:28PM +0100, Sylwester Nawrocki wrote: > ... >> +#define V4L2_CID_JPEG_ACTIVE_MARKERS >> (V4L2_CID_JPEG_CLASS_BASE + 4) > > Just a few comments. I like the approach, and I'd just remove the 'S' from > the CID name.
Thanks for your review. Ok, I'll make it singular form. I was going back and forth with that, and in last minute even forgot to make it consistent in the DocBook patches. I think we need to also redesign VIDIOC_S/G_JPEGCOMP ioctls, to support quantization and Huffman tables setup. My idea was to firstly add the controls support in drivers, let some time for application to start using them (1 year or so), then remove VIDIOC_S/G_JPEGCOMP support from drivers in question. Finally having very few drivers and applications using VIDIOC_S/G_JPEGCOMP we could deprecate those ioctls and add new ones. As of now only two drivers are using S/G_JPEGCOMP for anything else than image quality and the markers, with gspca being main user. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
