Hi Laurent, On Mon, Mar 05, 2012 at 12:47:26PM +0100, Laurent Pinchart wrote: > Hi Sakari, > > Thanks for the patch.
Thanks for the comments! > On Friday 02 March 2012 19:30:17 Sakari Ailus wrote: > > Add documentation for V4L2 subdev selection API. This changes also > > experimental V4L2 subdev API so that scaling now works through selection API > > only. > > > > Signed-off-by: Sakari Ailus <sakari.ai...@iki.fi> > > [snip] > > > diff --git a/Documentation/DocBook/media/v4l/dev-subdev.xml > > b/Documentation/DocBook/media/v4l/dev-subdev.xml index 0916a73..ef99da1 > > 100644 > > --- a/Documentation/DocBook/media/v4l/dev-subdev.xml > > +++ b/Documentation/DocBook/media/v4l/dev-subdev.xml > > [snip] > > > + <para>The scaling operation changes the size of the image by > > + scaling it to new dimensions. The scaling ratio isn't specified > > + explicitly, but is implied from the original and scaled image > > + sizes. Both sizes are represented by &v4l2-rect;.</para> > > + > > + <para>Scaling support is optional. When supported by a subdev, > > + the crop rectangle on the subdev's sink pad is scaled to the > > + size configured using &sub-subdev-g-selection; and > > + <constant>V4L2_SUBDEV_SEL_COMPOSE_ACTIVE</constant> selection > > + target on the same pad. If the subdev supports scaling but no > > s/no/not/ (my bad, typo in my previous review) > > > + composing, the top and left values are not used and must always > > + be set to zero."</para> > > s/"// (don't copy the text blindly ;-)) Fixed. > > + <section> > > + <title>Order of configuration and format propagation</title> > > + > > + <para>Inside subdevs, the order of image processing steps will > > + always be from the sink pad towards the source pad. This is also > > + reflected in the order in which the configuration must be > > + performed by the user: the changes made will be propagated to > > + any subsequent stages. If this behaviour is not desired, the > > + user must set > > + <constant>V4L2_SUBDEV_SEL_FLAG_KEEP_CONFIG</constant> flag. This > > + flag causes that no propagation of the changes are allowed in > > + any circumstances. This may also cause the accessed rectangle to > > + be adjusted by the driver, depending on the properties of the > > + underlying hardware. Some drivers may not support this > > + flag.</para> > > Haven't we agreed that supporting the flag should be mandatory ? Yes, but it may have been after I sent the patchset. Nevertheless, it's fixed now. > > + <para>The coordinates to a step always refer to the active size > > + of the previous step. The exception to this rule is the source > > + compose rectangle, which refers to the sink compose bounds > > + rectangle --- if it is supported by the hardware.</para> > > [snip] > > > diff --git a/Documentation/DocBook/media/v4l/vidioc-subdev-g-selection.xml > > b/Documentation/DocBook/media/v4l/vidioc-subdev-g-selection.xml new file > > mode 100644 > > index 0000000..da1cc4f > > --- /dev/null > > +++ b/Documentation/DocBook/media/v4l/vidioc-subdev-g-selection.xml > > [snip] > > > + <section> > > + <title>Types of selection targets</title> > > + > > + <para>The are two types of selection targets: active and bounds. > > s/The/There/ Fixed. Regards, -- Sakari Ailus e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
