On Thu, Apr 19, 2012 at 04:44:44PM -0400, Jarod Wilson wrote: > On Wed, Apr 18, 2012 at 09:54:07PM +0100, Luis Henriques wrote: > > An early registration of an ISR was causing a crash to several users (for > > example here: http://bugs.launchpad.net/bugs/972723 The reason was that > > IRQs were being triggered before the driver initialisation was completed. > > > > This patch fixes this by moving the invocation to request_irq() to a later > > stage on the driver probe function. > > Ugh. Looks like we actually have a similar problem with multiple lpc super > i/o based CIR drivers. I'd probably move both the irq and io region > requests in ite-cir, fintek-cir, nuvoton-cir, ene_ir and winbond-cir. If > I'm thinking clearly, I've actually seen a very similar report for one of > the other CIR drivers recently. Good catch. But yeah, lets do the same for > all the drivers, and move request_region as well.
Yeah, I've realised the other drivers had the same issue. ite-cir was just for one that bit us first. Anyway, I'll be sending in a minute another patch with your comments. Cheers, -- Luis -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
