On 08/25/2012 10:05 PM, Jose Alberto Reguero wrote:
This patch add support to the Avermedia Twinstar double tuner in the
af9035 driver.
This time the patch inline because it was rejected. Also patch was
malformed.
Signed-off-by: Jose Alberto Reguero <[email protected]
<mailto:[email protected]>>
Jose Alberto
Hello Jose, and thank you very much to hack this important and missing
piece of AF9035 driver functionality.
I looked it quickly and here is the comments so far. I will try to
review it more carefully tomorrow.
* your patch is very hard to read/review as you used some diff option
that does not show function name whom code is changed
* there is two new configuration parameters for af9033 demod. I don't
understand why. As I don't see any need / use for those I want you to
remove those. Configurations structures are something not to add any
extra parameters "just for fun". Use "ts_mode != AF9033_TS_MODE_USB"
instead of "second". Other parameter "tuner_address" is not used at all
for af9033.
* MXL5007T is not my driver. There seems to be new parameters no_probe
and no_reset. Those sounds also something that could be avoided. But I
didn't looked that code and I am not sure. Add at least comment why
those are used as such parameters deviates from normal use.
Could you also sent small sniff for me where is dual tuner used?
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
