On Fri, Oct 05, 2012 at 21:14:25, Andrei Mandychev wrote: > If there is a buffer with VIDEOBUF_QUEUED state it won't be deleted properly > because the head of queue loses its elements by calling INIT_LIST_HEAD() > before videobuf_streamoff().
"dma_queue" is driver internal queue and videobuf_streamoff() function will end up into buf_release() callback, which in our case doesn't do anything with dmaqueue. Did you face any runtime issues with this? I still did not understand about this corruption thing. Thanks, Vaibhav > --- > drivers/media/video/omap/omap_vout.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/video/omap/omap_vout.c > b/drivers/media/video/omap/omap_vout.c > index 409da0f..f02eb8e 100644 > --- a/drivers/media/video/omap/omap_vout.c > +++ b/drivers/media/video/omap/omap_vout.c > @@ -1738,8 +1738,8 @@ static int vidioc_streamoff(struct file *file, void > *fh, enum v4l2_buf_type i) > v4l2_err(&vout->vid_dev->v4l2_dev, "failed to change mode in" > " streamoff\n"); > > - INIT_LIST_HEAD(&vout->dma_queue); > ret = videobuf_streamoff(&vout->vbq); > + INIT_LIST_HEAD(&vout->dma_queue); > > return ret; > } > -- > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
