On Monday, April 22, 2013 14:12:57 Mauro Carvalho Chehab wrote:
> Em 22-04-2013 04:22, Hans Verkuil escreveu:
> > On Sun April 21 2013 21:00:37 Mauro Carvalho Chehab wrote:
> >> Instead of using global values for tuner ranges, store them
> >> internally. That fixes the need of using a different range
> >> for SDR radio, and will help to latter add a tuner ops to
> >> retrieve the tuner range for SDR mode.
> >>
> >> Signed-off-by: Mauro Carvalho Chehab <mche...@redhat.com>
> >> ---
> >> drivers/media/v4l2-core/tuner-core.c | 59
> >> ++++++++++++++++++++++--------------
> >> 1 file changed, 37 insertions(+), 22 deletions(-)
> >>
> >> diff --git a/drivers/media/v4l2-core/tuner-core.c
> >> b/drivers/media/v4l2-core/tuner-core.c
> >> index e54b5ae..abdcda4 100644
> >> --- a/drivers/media/v4l2-core/tuner-core.c
> >> +++ b/drivers/media/v4l2-core/tuner-core.c
> >> @@ -67,8 +67,8 @@ static char secam[] = "--";
> >> static char ntsc[] = "-";
> >>
> >> module_param_named(debug, tuner_debug, int, 0644);
> >> -module_param_array(tv_range, int, NULL, 0644);
> >> -module_param_array(radio_range, int, NULL, 0644);
> >> +module_param_array(tv_range, int, NULL, 0444);
> >> +module_param_array(radio_range, int, NULL, 0444);
> >
> > Shouldn't we add a sdr_range here as well?
>
> I don't think it is needed to have a modprobe parameter for that.
> If user wants to change the range, VIDIOC_S_TUNER can be used.
You can't change the range using S_TUNER, it's not a settable field.
>
> Btw, I was tempted to even remove those ;)
I'd either remove them or add an sdr_range rather than leaving it in
an inconsistent state.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
